Run apollo-compiler in the background #83
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
reviewed
Nov 6, 2025
Comment on lines
+266
to
+267
| apolloCompilerCodegenJob = coroutineScope.launch { | ||
| ApolloCompilerHelper(project).generateAllSources() |
Contributor
There was a problem hiding this comment.
generateAllSources() is 100% blocking code IIRC. There is no need for a coroutine, a plain Executor should be enough. Also worth noting that you may end up with multiple compilation happening in parallel (not safe) if you start/stop/start/stop quickly.
Collaborator
Author
There was a problem hiding this comment.
The guide recommends using coroutines with the provided scope to do background work nowadays, also saying that blocking code is OK. But the doc (+ situation with different versions of IDEs) is kind of messy and I'm actually not sure about whether job.cancel() actually works here. I'll test a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.