Skip to content

Remove ignoreResults from MutationOptionsDocumentation and MutationResultDocumentation #12947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

Remove ignoreResults from MutationOptionsDocumentation and MutationResultDocumentation #12947

merged 3 commits into from
Sep 30, 2025
+3 −15

Conversation

@simPod
Copy link
Contributor

@simPod simPod commented Sep 28, 2025 •
edited
Loading

Those has been removed in v4

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb3e2a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simPod simPod changed the title Remove ignoreResults from MutationOptionsDocumentation and MutationResultDocumentation fix: remove undefined from MutateResult.data type Sep 28, 2025
@simPod
Copy link
Contributor Author

simPod commented Sep 28, 2025

Umm I'm no longer sure what's correct.

The problem is that I receive data: T|undefined in mutate().then(data: T|undefined => ...)

Though I think the undefined should not be there for success case.

jerelmiller
jerelmiller requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch about ignoreResults! Let's keep that change.

Unfortunately the undefined is correct in the return type so let's leave that for now.

@simPod simPod force-pushed the ignore-results branch 2 times, most recently from f67d118 to 66dbf93 Compare September 30, 2025 07:58
@simPod simPod changed the title fix: remove undefined from MutateResult.data type Remove ignoreResults from MutationOptionsDocumentation and MutationResultDocumentation Sep 30, 2025
@simPod simPod changed the title Remove ignoreResults from MutationOptionsDocumentation and MutationResultDocumentation Remove ignoreResults from MutationOptionsDocumentation and MutationResultDocumentation Sep 30, 2025
@simPod simPod requested a review from jerelmiller September 30, 2025 07:59
@simPod
Remove ignoreResults from MutationOptionsDocumentation and MutationRe…
045de24 
…sultDocumentation

Those has been removed in v4
jerelmiller
jerelmiller approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jerelmiller jerelmiller merged commit e3ce6c6 into apollographql:main Sep 30, 2025
32 checks passed
@simPod simPod deleted the ignore-results branch September 30, 2025 21:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simPod @jerelmiller