Fix fuzzing ci job #99
Conversation
No manual changes, just run the script so we are in a "clean" state.
The `generate-files.sh` script was copied from `rust-bitcoin`, looks like who ever copied it forgot to read it (*cough* Tobin) ;) Use yaml pipe syntax to write multiline shell code; use the correct cfg flags, echoing them before running the fuzz script.
|
CI is failing, @apoelstra:
|
Because this is the version that works with honggfuzz. Stable stopped working (at least for a while) and earlier versions don't work.
Yeah, we can switch to 1.69 for this crate. It looks like I'm using 1.64 locally, which also works.
It started failing now because this is the first time we're running the fuzz tests in CI, and the offending code is gated on the fuzz cfg flag. I encountered this a few weeks ago after merging #98, and forgot about it, sorry. But no, let's not use stable, that'll break. Let's just pick a version that works. |
Rust 1.58 doesn't like usage of `Mutex`, switching to Rust 1.69 for fuzzing resolves the issue. Do not use `stable` because it has broken in the past with `hongfuzz`.
|
All green - party. |
|
Will just review/merge #100. |
bdda5e8 bump version to 0.15.0 (Tobin C. Harding) 87338f3 Use Rust 1.69 to run the fuzzer (Tobin C. Harding) 89930cc fuzz: Use correct cfg flags (Tobin C. Harding) d50b5a8 Run fuzz/generate-files.sh (Tobin C. Harding) Pull request description: Release 0.15.0 - like its our job! On top of #99, needs rebase after that merges. ACKs for top commit: apoelstra: ACK bdda5e8 Tree-SHA512: df2fdaf6f2b53466c20f1d3dccca485da5f7baeed03d1369ad6c1a6c941b7a1842cabf7e3fa93b99591265ded017fb8247602414213d4cce84f6a3cf36452fc2
2 participants
Fix fuzzing introduced in #94. Patch one is cleanup, patch 2 is the fix.
Hey @apoelstra, you could consider just merging #100 since it includes this.