Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Conversation

@darosior
Copy link
Contributor

To make #103 and #102 available downstream. Note i've successfully tested #103 in my software (detect and retry requests to bitcoind upon hitting a transient workqueue exceeded error).

Updating the Error enum for minreq_http is an API break, so bump the major version.

darosior added 3 commits June 29, 2023 17:39
Cargo was throwing unused warnings otherwise
Updating the Error enum for minreq_http is an API break, so bump the
major version.
@darosior
Copy link
Contributor Author

darosior commented Jun 29, 2023

Added 2 commits before the release commit. One asked by @apoelstra on IRC to avoid a breaking change if we add more variants to the Error enum in the future, and one nit i noticed while running the unit tests locally.

Copy link
Collaborator

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b34d4a

Copy link
Owner

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b34d4a

@apoelstra apoelstra merged commit b8c3f0d into apoelstra:master Jun 29, 2023
@apoelstra
Copy link
Owner

Tagged and published.

@darosior
Copy link
Contributor Author

darosior commented Jun 29, 2023 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants