Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ruby): add support of additional properties #48

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

MaryamAdnan3
Copy link
Collaborator

@MaryamAdnan3 MaryamAdnan3 commented Nov 6, 2024

What

This PR includes the changes of support of typed additional properties and tests around it.

Why

To add support for the typed additional properties in the SDK

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

Tests were added in api_helper_test.rb

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@MaryamAdnan3 MaryamAdnan3 added the enhancement New feature or request label Nov 6, 2024
@MaryamAdnan3 MaryamAdnan3 self-assigned this Nov 6, 2024
@MaryamAdnan3 MaryamAdnan3 linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above mentioned comments need your attention.

Copy link
Collaborator

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above mentioned comment needs your attention

sufyankhanrao
sufyankhanrao previously approved these changes Nov 11, 2024
Copy link

Copy link

@haseeb-mhr haseeb-mhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryamAdnan3 MaryamAdnan3 merged commit 606255f into main Nov 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for typed additional properties
4 participants