Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use vitestover jest for code testing #152

Merged
merged 2 commits into from
Feb 3, 2025
Merged

chore: use vitestover jest for code testing #152

merged 2 commits into from
Feb 3, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Feb 3, 2025

Following recent jest issues in PRs (e.g. #151), we decided to switch the testing framework to vitest. Most modern apify projects seem to use vitest anyway and the API is similar enough (see changes below). The native ESM support is a huge plus, too.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 3, 2025
@barjin barjin self-assigned this Feb 3, 2025
@github-actions github-actions bot added this to the 107th sprint - Tooling team milestone Feb 3, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Feb 3, 2025
@barjin barjin merged commit a1b29d3 into master Feb 3, 2025
8 checks passed
@barjin barjin deleted the chore/vitest branch February 3, 2025 12:47
@B4nan
Copy link
Member

B4nan commented Feb 3, 2025

lets also add node 22 to the workflow

This was referenced Feb 3, 2025
Merged
Merged
barjin added a commit that referenced this pull request Feb 3, 2025
@barjin
chore(ci): test against Node 22, update GH Actions (#153)
c34baa2 
Uses Node 22 in CI for build and testing purposes as discussed under
#152 . Updates third-party GitHub Actions to their latest versions.

Bumps the package version to `4.1.0` to fix the prerelease publish for
#151 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees

@barjin barjin

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
107th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@barjin @B4nan