Skip to content

feat: iri search filter #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: iri search filter #7079

wants to merge 1 commit into from

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Apr 10, 2025

Q A
Branch? main
Tickets continues the work at #6865
License MIT
Doc PR TODO

bkosun
bkosun suggested changes Apr 10, 2025
View reviewed changes
tests/Fixtures/TestBundle/Document/Company.php
@@ -22,7 +22,7 @@
use Symfony\Component\Serializer\Annotation\Groups;

#[ApiResource]
#[GetCollection]
#[GetCollection()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[GetCollection()]
#[GetCollection]

tests/Fixtures/TestBundle/Entity/Company.php
@@ -22,7 +22,7 @@
use Symfony\Component\Serializer\Annotation\Groups;

#[ApiResource]
#[GetCollection]
#[GetCollection()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[GetCollection()]
#[GetCollection]

vinceAmstoutz
vinceAmstoutz suggested changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these suggestions will solve the 2 PHPStan errors & some tests failures @soyuka

src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php
Comment on lines +120 to +121
if (null === $parameter->getProvider() && (($f = $parameter->getFilter()) && $f instanceof ParameterProviderFilterInterface)) {
$parameters->add($key, $parameter->withProvider($f->getParameterProvider()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (null === $parameter->getProvider() && (($f = $parameter->getFilter()) && $f instanceof ParameterProviderFilterInterface)) {
$parameters->add($key, $parameter->withProvider($f->getParameterProvider()));
if (null === $parameter->getProvider() && (($filter = $parameter->getFilter()) && $f instanceof ParameterProviderFilterInterface)) {
$parameters->add($key, $parameter->withProvider($filter->getParameterProvider()));

tests/Fixtures/TestBundle/Document/Chicken.php
class Chicken
{
#[ODM\Id]
private string $id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private string $id;
private ?string $id = null;

tests/Fixtures/TestBundle/Document/ChickenCoop.php
use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;

#[ODM\Document]
#[GetCollection(normalizationContext: ['hydra_prefix' => false], parameters: ['chickens' => new QueryParameter(filter: new IriFilter())])]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[GetCollection(normalizationContext: ['hydra_prefix' => false], parameters: ['chickens' => new QueryParameter(filter: new IriFilter())])]
#[GetCollection(
normalizationContext: ['hydra_prefix' => false],
parameters: ['chickens' => new QueryParameter(filter: new IriFilter())]
)]

tests/Fixtures/TestBundle/Entity/Chicken.php
use Doctrine\ORM\Mapping as ORM;

#[ORM\Entity]
#[Get()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[Get()]
#[Get]

tests/Fixtures/TestBundle/Document/ChickenCoop.php

namespace ApiPlatform\Tests\Fixtures\TestBundle\Document;

use ApiPlatform\Doctrine\Orm\Filter\IriFilter;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use ApiPlatform\Doctrine\Orm\Filter\IriFilter;
use ApiPlatform\Doctrine\Odm\Filter\IriFilter;

tests/Fixtures/TestBundle/Document/ChickenCoop.php
use ApiPlatform\Doctrine\Orm\Filter\IriFilter;
use ApiPlatform\Metadata\GetCollection;
use ApiPlatform\Metadata\QueryParameter;
use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Chicken;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Chicken;
use ApiPlatform\Tests\Fixtures\TestBundle\Document\Chicken;

tests/Fixtures/TestBundle/Entity/ChickenCoop.php
use Doctrine\ORM\Mapping as ORM;

#[ORM\Entity]
#[GetCollection(normalizationContext: ['hydra_prefix' => false], parameters: ['chickens' => new QueryParameter(filter: new IriFilter())])]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[GetCollection(normalizationContext: ['hydra_prefix' => false], parameters: ['chickens' => new QueryParameter(filter: new IriFilter())])]
#[GetCollection(
normalizationContext: ['hydra_prefix' => false],
parameters: ['chickens' => new QueryParameter(filter: new IriFilter())]
)]

@vinceAmstoutz vinceAmstoutz mentioned this pull request Apr 11, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkosun bkosun bkosun requested changes

@vinceAmstoutz vinceAmstoutz vinceAmstoutz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soyuka @bkosun @vinceAmstoutz