Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokenization exceptions and detect some false positive EOS #192

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Add tokenization exceptions and detect some false positive EOS #192

merged 2 commits into from
Mar 7, 2023

Conversation

percevalw
Copy link
Member

Description

This PR aims at:

  • fixing some syntax issues in the tokenization regex (how was it even running before ??)
  • detecting false positive end-of-sentence periods: tokenization exceptions (Mr., Dr., Mrs.) and acronym periods such as those found in ADICAP codes B.H.HP.A7A0
  • updating ADICAP patterns to fix the issue raised by cf Adicap : enhancement of regex to match local spelling #158

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@percevalw percevalw merged commit 26b07e0 into master Mar 7, 2023
@percevalw percevalw mentioned this pull request Mar 7, 2023
Closed
@percevalw percevalw deleted the fix-tokenizer branch November 14, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricohen93 aricohen93 aricohen93 approved these changes

@etienneguevel etienneguevel Awaiting requested review from etienneguevel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@percevalw @aricohen93