Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
From dev meeting:
|
tofu-rocketry
force-pushed
the
issue235
branch
2 times, most recently
from
6ff87dc to
7d99827
Compare
This fixes issues with the item count being wrong and whole directories being passed on to the sender.
tofu-rocketry
force-pushed
the
issue235
branch
from
7d99827 to
afe46aa
Compare
This reverts commit afe46aa as the file filtering needs to be implmented earlier in the code.
tempfile creates files and folders with a random name, but adds the prefix directly before it, so this makes it more readable by separating those parts.
tofu-rocketry
force-pushed
the
issue235
branch
from
6967cd2 to
1defe69
Compare
Previous version of test failed in Ubuntu Travis environment, possibly due to the file being kept open in the context manager.
William-Brown5515
pushed a commit
to William-Brown5515/ssm
that referenced
this pull request
Nov 20, 2024
246 no cloudtype primary key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #235
I was unsure which files needed to be checked but I think checked the right ones so they are only appended if they are files that exist.