Skip to content

Adjust Left and right padding on sections#31

Open
AlbinaMidwestern wants to merge 5 commits into
masterfrom
albinazemskova/ch20871/adjust-left-and-right-padding-on-sections
Open

Adjust Left and right padding on sections#31
AlbinaMidwestern wants to merge 5 commits into
masterfrom
albinazemskova/ch20871/adjust-left-and-right-padding-on-sections

Conversation

@AlbinaMidwestern
Copy link
Copy Markdown
Collaborator

fixes #16

@Jared-Dev
Copy link
Copy Markdown
Contributor

Jared-Dev commented May 11, 2021

The description doesn't match the "ask" on this one.

The container that has the social media icons needs 115px of top padding.
The container that has the chimp in it needs 100px of bottom padding.

@AlbinaMidwestern

@Jared-Dev
Copy link
Copy Markdown
Contributor

@AlbinaMidwestern Looks like the donation card isn't respecting widths. This is again, roughly 900px wide.

image

@Jared-Dev
Copy link
Copy Markdown
Contributor

image

Looks like the left/right spacing still might not be lining up. Can you double check this? Also, the top and bottom padding looks like it might be way too tight. Is that fixed in your other PR?

@AlbinaMidwestern
Copy link
Copy Markdown
Collaborator Author

Added margin top between section in this PR
Also check again donation card width and video. In my browser it looks normal
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust Left and right padding on sections

2 participants