Skip to content

ZOOKEEPER-3624: Fix flaky QuorumPeerMainTest::testFailedTxnAsPartOfQuorumLoss#2204

Merged
anmolnar merged 1 commit intoapache:masterfrom
kezhuw:ZOOKEEPER-3624-fix-flaky-testFailedTxnAsPartOfQuorumLoss
Jan 3, 2025
Merged

ZOOKEEPER-3624: Fix flaky QuorumPeerMainTest::testFailedTxnAsPartOfQuorumLoss#2204
anmolnar merged 1 commit intoapache:masterfrom
kezhuw:ZOOKEEPER-3624-fix-flaky-testFailedTxnAsPartOfQuorumLoss

Conversation

@kezhuw
Copy link
Copy Markdown
Member

@kezhuw kezhuw commented Oct 18, 2024

org.opentest4j.AssertionFailedError: create /zk2 should have failed
	at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:762)

The test starts other members before the create operation. This causes
the old leader rejoin with them to form quorum.

This pr moves starting of stopped members after create.

…uorumLoss`

```
org.opentest4j.AssertionFailedError: create /zk2 should have failed
	at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:762)
```

The test starts other members before the `create` operation. This causes
the old leader rejoin with them to form quorum.

This pr moves starting of stopped members after `create`.
Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anmolnar anmolnar merged commit a8eb7fa into apache:master Jan 3, 2025
@kezhuw kezhuw deleted the ZOOKEEPER-3624-fix-flaky-testFailedTxnAsPartOfQuorumLoss branch January 6, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants