[ZEPPELIN-6221] Optimize Neo4jCypherInterpreterTest performance by reusing interpreter instance #4983
+10
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR optimizes the performance of Neo4jCypherInterpreterTest by eliminating redundant interpreter initialization.
Currently, each test method creates and closes a new Neo4jCypherInterpreter instance, which introduces unnecessary overhead when running against a Neo4j Testcontainer.
By using @testinstance(TestInstance.Lifecycle.PER_CLASS) and moving setup to @BeforeAll, we reduce initialization from 11 times to 1 time, improving test execution time.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
mvn test -Dtest=Neo4jCypherInterpreterTest
Screenshots (if appropriate)
N/A
Questions: