[YUNIKORN-3142] Calculate Preemptable Resource for leaf Queue with same resource types #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
=======================================
Coverage 81.50% 81.51%
=======================================
Files 102 102
Lines 13337 13354 +17
=======================================
+ Hits 10870 10885 +15
- Misses 2208 2209 +1
- Partials 259 260 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does this depend on #1038 ? I can see overlapping changes here. |
…me resource types
manirajv06
force-pushed
the
YUNIKORN-3142
branch
from
c8b6d5e to
0297e10
Compare
Rebased the changes. |
pbacsko
reviewed
Nov 5, 2025
| maxRes := qcp.queue.CloneMaxResource() | ||
| used := resources.SubOnlyExisting(qcp.queue.GetAllocatedResource(), qcp.queue.GetPreemptingResource()) | ||
| if maxRes.IsEmpty() || used.IsEmpty() { | ||
| return nil |
There was a problem hiding this comment.
Nit: wouldn't it be safer to always return something instead of "nil"? To me, a resources.Zero() seems to be more appropriate.
Comment on lines
+75
to
+77
| if preemptableResource.IsEmpty() { | ||
| return nil | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Calculate Preemptable Resource for the leaf queue.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3142
How should this be tested?
Screenshots (if appropriate)
Questions: