Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes four small correctness holes in Relax transformation passes:
AdjustMatmulOrderfrom reassociating a rank-one middle operand, whose row/column interpretation changes across the two orders;make_closure;tensor_to_shapeconstants using their actual int16/int32/int64 storage dtype inFoldConstant;LambdaLiftand choose the invoke op from the function's purity.The changes are local to the affected passes and retain the existing behavior for supported controls.
Closes #20492
Closes #20493
Closes #20495
Closes #20497
Tests:
pytest tests/python/relax/test_transform_remove_unused_outputs.py tests/python/relax/test_transform_fold_constant.py tests/python/relax/test_transform_lambda_lift.py -q(36 passed)cmake --build build --parallel 3(completed, including all four modified C++ sources)