Conversation
Signed-off-by: Akaash Parthasarathy <akaashrp@gmail.com>
Signed-off-by: Akaash Parthasarathy <akaashrp@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeShapeTuplereturns the object the shape cache owns. The cache is a 256-entry LRU that disposes what it evicts, so once a prefill touches more than 256 distinct shapes a caller can hold a tuple that has already been freed. WebLLM hits this on a Radeon iGPU asObject has already been disposedfollowed by a device hang (mlc-ai/web-llm#844). #20130 kept evicted tuples alive until teardown, whereas here the tuple is owned by the caller.makeShapeTupletakes a reference on the cached handle and returns a new object attached to the current scope, so eviction only drops the cache's reference. Like every other function that returns a TVM object, it now requires an open scope.setDeviceLostAutoDispose(false)lets an owner that already disposes the instance itself keep it from disposing on the device-lost promiseA cache hit costs 15 to 30 ns more per call. Tests cover eviction while a caller holds the tuple and deferred disposal after device loss.