Conversation
…anonicalizing CanonicalizeTIRVariables substitutes the known value of a symbolic variable into type annotations, but keeps a MatchCast whose variable is used at runtime. The argument of a later call_tir then keeps the variable while the call's out_ty had it replaced, and the call_tir validator added in apache#20480 rejects the pair. The same happens when two MatchCasts rename one dimension, since a value is substituted one level at a time. Canonicalize the arguments first and derive the type they imply. Use the canonical out_ty when it still follows from the arguments, otherwise the implied type. Expose InferCallTIROutputTypeFromArguments for that. MLC LLM hit this compiling Phi-3.5-vision after the pin moved past apache#20480.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CanonicalizeTIRVariablessubstitutes the known value of a symbolic variable into type annotations, but keeps aMatchCastwhose variable is used at runtime. The argument of a latercall_tirthen still carries the variable while the call'sout_tyhad it replaced, and thecall_tirvalidator from #20480 rejects the pair:The same happens when two
MatchCasts rename one dimension, because a value is substituted one level at a time. MLC LLM hits both while compiling Phi-3.5-vision.call_tir's arguments first and derive the type they imply. Keep the canonicalout_tywhen it still follows from the arguments, otherwise use the implied typeInferCallTIROutputTypeFromArgumentsinop_common.hfor thatMatchCastand for chainedMatchCasts