THRIFT-5744: Switch to slog for go library #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
force-pushed
the
go-slog
branch
4 times, most recently
from
2c1eaeb to
0d89b7a
Compare
fishy
commented
Nov 17, 2023
| // | ||
| // If this is not called before calling Serve, context.Background() will be | ||
| // used. | ||
| func (p *TSimpleServer) SetLogContext(ctx context.Context) { |
There was a problem hiding this comment.
note: I used the term LogContext over BaseContext here as I intend this context to only be used for logging.
if we use it as base context to create ctx that we pass into processors and eventually handlers, then whatever developers set on the ctx to control the logging of TSimpleServer will also end up in their service handlers, which is most likely not intended and could be a big surprise.
dcelasun
approved these changes
Nov 18, 2023
fishy
force-pushed
the
go-slog
branch
3 times, most recently
from
d2dadfc to
ed416e1
Compare
fishy
force-pushed
the
go-slog
branch
2 times, most recently
from
bcbf152 to
10ba036
Compare
|
the go 1.22 github actions is not ready yet, will rerun github actions once that's ready. |
oh nevermind the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: go