Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated MSVC and clang-cl settings for Windows #2865

Merged

Conversation

emmenlau
Copy link
Member

This PR makes a minor improvement when building with LLVM clang-cl on Windows. One of the compile flags is not needed by clang-cl and should only be used with MSVC compilers.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@emmenlau emmenlau self-assigned this Oct 11, 2023
@emmenlau emmenlau merged commit 006bc89 into apache:master Oct 11, 2023
3 checks passed
@emmenlau emmenlau deleted the emmenlau_minor_clangcl_improvement branch October 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant