Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TProtocol.h: Be extra careful when including MSVC Windows-related headers #2862

Merged

Conversation

emmenlau
Copy link
Member

Windows-related headers can pollute the c++ namespace with macros min and max and other quirks that break standard c++ code quite easily.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G added the c++ label Oct 10, 2023
@emmenlau emmenlau force-pushed the emmenlau_fix_windows_header_include branch from f313ce9 to 49c6ec7 Compare October 12, 2023 07:31
@emmenlau
Copy link
Member Author

@emmenlau emmenlau merged commit 2810fd2 into apache:master Oct 12, 2023
10 of 11 checks passed
@emmenlau emmenlau deleted the emmenlau_fix_windows_header_include branch October 12, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants