Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with gcc 13 #2861

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix building with gcc 13 #2861

merged 1 commit into from
Oct 7, 2023

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Oct 5, 2023

This fixes the following compiler error.

t_js_generator.cc:48:14: error: 'int64_t' does not name a type
   48 | static const int64_t max_safe_integer = 0x1fffffffffffff;
      |              ^~~~~~~
t_js_generator.cc:50:14: error: 'int64_t' does not name a type
   50 | static const int64_t min_safe_integer = -max_safe_integer;
      |              ^~~~~~~
  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

This fixes the following compiler error.

t_js_generator.cc:48:14: error: 'int64_t' does not name a type
   48 | static const int64_t max_safe_integer = 0x1fffffffffffff;
      |              ^~~~~~~
t_js_generator.cc:50:14: error: 'int64_t' does not name a type
   50 | static const int64_t min_safe_integer = -max_safe_integer;
      |              ^~~~~~~
@Jens-G Jens-G merged commit 7b8c042 into apache:master Oct 7, 2023
21 of 25 checks passed
@Biswa96 Biswa96 deleted the gcc-stdint branch October 7, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants