Skip to content

Remove spec-only PresetService members #8611

Description

@aglinxinyuan

Task Summary

Three PresetService members have no production caller: updateOrCreatePreset, isValidNewOperatorPreset, and the exported PresetDictionary type.

History

Introduced by #1164 (2022-01-13) — "Add PresetService (User Presets Step 3)", which built out the preset API surface
Usage removed by never wired up — no production file has ever called updateOrCreatePreset or isValidNewOperatorPreset, and PresetDictionary has zero references worktree-wide. Only the service's own spec exercises them

The wired-up half of the service stays: savePresets, getPresets, applyPreset, isValidOperatorPreset, isValidPreset and the Ajv type guards all have live consumers, and common/formly/preset-wrapper/** calls none of the removed three.

Pure deletion, no behaviour change: −175 lines.

Task Type

  • Refactor / Cleanup

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions