[SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2253 +/- ##
=============================================
- Coverage 72.67% 44.58% -28.09%
+ Complexity 45775 26032 -19743
=============================================
Files 1474 1474
Lines 171628 171627 -1
Branches 33525 33525
=============================================
- Hits 124730 76524 -48206
- Misses 37470 90260 +52790
+ Partials 9428 4843 -4585 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e-strauss
force-pushed
the
tmp_code_cov
branch
2 times, most recently
from
bd2964b to
d67306b
Compare
…orUtils & JMLConnection
|
It looks like you have the same issue as Matthias on the main branch. We would have to look into this issue independently of the changes that you have made in this PR. |
e-strauss
changed the title
|
LGTM, the failed tests are independent of the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the test coverage of the API components: ScriptExecutorUtils () & jmlc.Connection (96.3%)