[SYNCOPE-1942] added getString to retrieve the label from localization properties file #1278
Conversation
…n properties file
ilgrosso
changed the title
ilgrosso
left a comment
ilgrosso
left a comment
There was a problem hiding this comment.
Besides what reported above, the same approach should be applied to extPages in the same way
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java
Outdated
Show resolved
Hide resolved
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java
Outdated
Show resolved
Hide resolved
| sessionExpiration.header=Session Expiration | ||
| sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working. | ||
| sessionExpiration.extend=Extend | ||
|
|
There was a problem hiding this comment.
These labels shall be provided in the same module where the corresponding page is located, e.g. ``client/idm/console/src/main/resources/...forTopology`
The other two labels are useless and should be removed.
There was a problem hiding this comment.
Removed labels for SRA and WA.
It seems that the labels are available only via the BasePage properties file. Creating a Topology properties file does not work, possibly because the IdmPages are dynamic.
There was a problem hiding this comment.
The menu is shown by all pages, which are all inheriting from BasPage, that's why putting the label in BasePage*.properties works.
You can't put it in Topology*.properties because otherwise all other pages will not know how to translate the Topology label.
There should be a way to move the translations with their own module, especially considering ext pages, which are currently not included in this PR but need to.
There was a problem hiding this comment.
I used the BasePage.properties file otherwise, the localized label would be visible only on the selected page. For example, the Home page would show the default label, while the Topology page would show the localized label. I think using BasePage is also a logical choice, since we are referring to the menu.
There was a problem hiding this comment.
Maybe you can have a look at Wicket docs and come up with something that actually solves a general issue rather than just enabling the translation of Topology - because this is all that this PR seems to be about, while there is actually room for some serious improvement.
Summarizing:
- come up with a solution which allows to plug-in translations for page menu items, whether such pages are idm, am or ext
- find a way to leave the labels in the same source module where the page is
There was a problem hiding this comment.
Pushed a new version with dynamic property reading. With this approach, the label is read from a property file located in the same package as the page. All pages with these annotations (IdmPages, AmPages, ExtPages) will be managed automatically.
|
@massx1 welcome back! |
done |
...n-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuStringResourceLoader.java
Outdated
Show resolved
Hide resolved
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class DynamicMenuRegister { |
There was a problem hiding this comment.
If you place this class under UI commons, I would expect it to be used by both Console and Enduser, which I don't think is the case.
The correct placement would be in client-idrepo-console.
Secondly, there is no need to work with static: Console is a Spring Boot application, you can define a Bean.
There was a problem hiding this comment.
Yes It's used by both...
Static should be necessary to have the same instance Map for all the used classes.
2 participants
No description provided.