Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51663][SQL] Short circuit && operation for JoinSelectionHelper #50455

Closed
wants to merge 1 commit into from

Conversation

beliefer
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to improve by short circuit && operation for JoinSelectionHelper.

Why are the changes needed?

Short circuit && operation for JoinSelectionHelper and reduce a little of overhead.

Does this PR introduce any user-facing change?

'No'.

How was this patch tested?

GA.

Was this patch authored or co-authored using generative AI tooling?

'No'.

@github-actions github-actions bot added the SQL label Mar 30, 2025
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about another place:

canBuildShuffledHashJoinLeft(join.joinType) && buildLeft,
canBuildShuffledHashJoinRight(join.joinType) && buildRight,

@beliefer
Copy link
Contributor Author

@beliefer beliefer closed this in be8489f Mar 31, 2025
@beliefer
Copy link
Contributor Author

@MaxGekk @LuciferYang Thank you!
Merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants