[SPARK-50683][SQL] Inline the common expression in With if used once #49310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan Thank you. |
|
CI failure is not relevant. |
cloud-fan
reviewed
Dec 27, 2024
| @@ -68,9 +68,15 @@ object RewriteWithExpression extends Rule[LogicalPlan] { | |||
|
|
|||
| private def applyInternal(p: LogicalPlan): LogicalPlan = { | |||
| val inputPlans = p.children | |||
| val commonExprIdSet = p.expressions | |||
| .flatMap(_.collect { case r: CommonExpressionRef => r.id }) | |||
There was a problem hiding this comment.
We should avoid collecting references from nested With, as this rule skips nested With and leaves it to the next iteration.
There was a problem hiding this comment.
I think collecting references from nested With is necessary, e.g. With(ref0 + With(ref1 + ref1, Seq(def(ref0+b,1))), Seq(def(a+a,0))), first iteration will replace all ref0.
This will collect additional ref1, but it will not affect.
There was a problem hiding this comment.
ping gently @cloud-fan
|
The Spark Connect test failure is unrelated, thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title.
Why are the changes needed?
Simplify plan and reduce unnecessary project.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.