[SPARK-48458][SQL] Data loss in dynamic override fix #49295
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the run of InsertIntoHadoopFsRelationCommand, we should proactively detect if the spark session was stopped and fail fast in such cases, before any cleaning directories actions start.
Why are the changes needed?
When the dynamic partition override mode is turned on, there is a data corruption risk if a spark session is stopped in unlucky time for any reason.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run the exemplary gist on the top a local build:
Was this patch authored or co-authored using generative AI tooling?
No