[SPARK-50654][SS] CommitMetadata should set stateUniqueIds to None in V1 #49278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WweiL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Per request from this comment, https://github.com/apache/spark/pull/48355/files#r1866546734, we will put
Nonein thestateUniqueIdsofCommitMetadatawhen in V1. So now the logic is as follows:CommitMetadata.stateUniqueIds = Nonefor all stateful and stateless queriesCommitMetadata.stateUniqueIds = Some(Map.empty)for stateless queriesCommitMetadata.stateUniqueIds = Some(<non-empty-map>)for stateful queriesAlso removed the legacy test as a side effect
Why are the changes needed?
Follow up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No