always(?) use SolrCore.getLatestSchema in RealTimeGetComponent #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RealTimeGetComponent
usesgetLatestSchema
in 12 places andgetSchema
in 2 places.Intuitively I would expect
getSchema
to be used throughout since it as per https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/core/src/java/org/apache/solr/request/SolrQueryRequest.java#L86-L87 that is snapshot at request creation and so logically cannot change during processing. But based on 12:2 ratio perhapsgetLatestSchema
is equally suitable?This pull request is to always use
getLatestSchema
or to add clarifying comments w.r.t. why some places use one API and others use the other in the component.