Forbid 'String.matches(String)' API.#778
Draft
cpoerschke wants to merge 1 commit intoapache:mainfrom
Draft
Conversation
risdenk
requested changes
Oct 27, 2022
| } | ||
|
|
||
| private static Map<String, String> selectForIndex(int i, Map<String, String> original) { | ||
| final Pattern pattern = Pattern.compile("(((?!^router\\.).)*$|(^router\\." + i + ".*$))"); |
Contributor
There was a problem hiding this comment.
probably can make this a static final field?
|
|
||
| public static String[] validateCollections(String collections[]) { | ||
| String collectionNameRegex = "^[a-zA-Z0-9_-]*$"; | ||
| Pattern collectionNameRegexPattern = Pattern.compile("^[a-zA-Z0-9_-]*$"); |
Contributor
There was a problem hiding this comment.
probably can make this a static final field?
| path = request.substring(0, queryStartPos); | ||
| } | ||
| if (!query.matches(".*wt=schema\\.xml.*")) { // don't overwrite wt=schema.xml | ||
| final Pattern WT_SCHEMA_XML_PATTERN = Pattern.compile(".*wt=schema\\.xml.*"); |
Contributor
There was a problem hiding this comment.
This can probably be a static final field.
Contributor
|
This in general seems like a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In favour of reusable compiled patterns.
No JIRA issue as yet.