SOLR-15415 Use Embedded ZK in Tests #522
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrob
changed the title
madrob
commented
Jan 13, 2022
| @@ -73,8 +74,8 @@ public boolean isLikelyExpired(long timeToExpire) { | |||
| } | |||
| } | |||
|
|
|||
| public static abstract class IsClosed { | |||
| public abstract boolean isClosed(); | |||
| public interface IsClosed { | |||
|
|
||
| // we use this class to expose nasty stuff for tests | ||
| @SuppressWarnings({"try"}) | ||
| public class SolrZooKeeper extends ZooKeeper { |
| // best effort | ||
| } | ||
| } else { | ||
| // TODO? |
There was a problem hiding this comment.
Should this have the old reflection code that we used in SolrZooKeeper?
| @@ -30,6 +30,7 @@ | |||
| <Loggers> | |||
| <!-- Use <AsyncLogger/<AsyncRoot and <Logger/<Root for asynchronous logging or synchonous logging respectively --> | |||
| <Logger name="org.apache.zookeeper" level="WARN"/> | |||
| <Logger name="org.apache.zookeeper.PortAssignment" level="INFO"/> | |||
There was a problem hiding this comment.
This will go away later.
| .configuration(configuration) | ||
| .exitHandler(ExitHandler.LOG_ONLY) | ||
| .build(); | ||
| zkse.start(); |
There was a problem hiding this comment.
This really needs ZOOKEEPER-4312.
There was a problem hiding this comment.
Zookeeper is now on 3.8.0 so this should be possible.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -104,7 +99,7 @@ | |||
|
|
|||
| private volatile ZKDatabase zkDb; | |||
There was a problem hiding this comment.
UnusedVariable: The field 'zkDb' is never read. (details)
(at-me in a reply with help or ignore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for the first stage of SIP-14 https://cwiki.apache.org/confluence/display/SOLR/SIP-14+Embedded+Zookeeper
Not all tests are passing yet, but I wanted to put it up sooner than it was done since it does include changes to the public APIs in that I want to get rid of SolrZooKeeper class.