Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15869: expand LTRRescorer.rescore test coverage #470

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

SOLR-15869: expand LTRRescorer.rescore test coverage #470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05a8f3
SOLR-15869: expand LTRRescorer.rescore test coverage
cpoerschke Dec 22, 2021
1372751
TestLTRReRankingPipeline: one local variable rename for clarity
cpoerschke Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,16 @@ public void testDifferentTopN() throws IOException {

// test rerank with different topN cuts

// cap firstPassTopDocs length at topN
for (int topN = 1; topN <= 5; topN++) {
log.info("rerank {} documents ", topN);
log.info("rerank {} documents, return {} documents", topN, topN);
hits = searcher.search(bqBuilder.build(), 10);

final ScoreDoc[] slice = new ScoreDoc[topN];
System.arraycopy(hits.scoreDocs, 0, slice, 0, topN);
hits = new TopDocs(hits.totalHits, slice);
hits = rescorer.rescore(searcher, hits, topN);
assertEquals(topN, hits.scoreDocs.length);
for (int i = topN - 1, j = 0; i >= 0; i--, j++) {
if (log.isInfoEnabled()) {
log.info("doc {} in pos {}", searcher.doc(hits.scoreDocs[j].doc)
Expand All @@ -211,6 +213,25 @@ public void testDifferentTopN() throws IOException {

}
}

// use full firstPassTopDocs (possibly higher than topN)
for (int topN = 1; topN <= 5; topN++) {
final TopDocs allHits = searcher.search(bqBuilder.build(), 10);
log.info("rerank {} documents, return {} documents", allHits.scoreDocs.length, topN);

TopDocs rescoredHits = rescorer.rescore(searcher, allHits, topN);
assertEquals(topN, rescoredHits.scoreDocs.length);
for (int i = allHits.scoreDocs.length-1, j = 0; i >= 0 && j < topN; i--, j++) {
if (log.isInfoEnabled()) {
log.info("doc {} in pos {}", searcher.doc(rescoredHits.scoreDocs[j].doc)
.get("id"), j);
}
assertEquals(i,
Integer.parseInt(searcher.doc(rescoredHits.scoreDocs[j].doc).get("id")));
assertEquals((i + 1) * features.size()*featureWeight, rescoredHits.scoreDocs[j].score, 0.00001);

}
}
}
}

Expand Down