SOLR-17707 HttpJdkSolrClient handle exceptions #3273
Draft
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try (source) { | ||
| contentWriter.write(source); | ||
| contentWritingFuture.complete(null); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Can you change this to Throwable? We don't want a possibility of this not being caught.
|
the PR is very drafty; I started editing this PR locally but then held myself back to insist we see a test before guessing anything we do works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17707
Description
Threads hung during indexing data to Solr with HttpJdkSolrClient
Solution
Catch and propagate exceptions during piping from src to dst..
Disclaimer: Current PR is a solution suggested by GitHub CoPilot AI after describing the problem. I do not actually have a deep insight into exception handling in such a scenario, but existing tests do pass :) Would be nice with a dedicated test too.
Tests
TBD Would need to write a test that triggers an exception during write, how?
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.