-
Notifications
You must be signed in to change notification settings - Fork 739
SOLR-17043: Remove SolrClient path pattern matching #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
08fa4e8
Change getRequestType and update CloudSolrClient
4ba37c4
Deprecate IsUpdateRequest
8ded9cf
Remove references to ADMIN_PATHS
9a06708
Add getBaseRequestType for more complex use cases
48cb77b
spotlessApply
0a47d38
Use getBaseRequestType for everything
3188648
getBaseRequestType should be protected, not public
7d891a6
Fix request routing for misclassified requests
654beb6
doc wording
e262274
gradlew check
37ecfe8
Fix Javadoc warning
5ff4c37
Make getRequestType final
1204f32
Replace getBaseRequestType with a defaultType field
46330f4
typo
7d7b9ee
Make requestType an explicit constructor param
605ff05
Move sendToLeaders to UpdateReqeust
73d92e9
Restore request types of V2Request and FieldAnalysisRequest
ae4f8db
Remove extra logic in SolrRequest, fix CloudSolrClient issue, and sta…
16c52b4
spotlessApply
63463f8
Fix 11/23 failing test
baacbc1
Fix remaining tests
5237b0b
Fix TestRebalanceLeaders
57ac132
typo
fe7afc4
Remove IsUpdateRequest from AbstractUpdateRequest
a8af543
Fix CollectionRequiringSolrRequest
9a714cb
Remove unnecessary deps
a0082c5
Make sure logic matches in LBSolrClient
4822570
Minor review feedback cleanup
gerlowskija 481afeb
Fix 'check'
gerlowskija 7dd4bdc
Merge branch 'main' into feat/SOLR-17043
gerlowskija e4d0141
Add CHANGES.txt entry
gerlowskija File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.