LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrob
reviewed
Jul 7, 2021
| factoryDefault.inform(loader); | ||
|
|
||
| TokenStream ts = factoryDefault.create(whitespaceMockTokenizer(testText)); | ||
| BaseTokenStreamTestCase.assertTokenStreamContents(ts, | ||
| new String[] { "I", "borrowed", "5", "540000", "400", "00", "at", "25", "interest", "interestrate", "rate" }); | ||
| new String[] { "I", "borrowed", "540000", "5", "400", "00", "at", "25", "interestrate", "interest", "rate" }); |
There was a problem hiding this comment.
Slightly concerning here that we are dependent on order from something that I presume is not order-defined.
|
Converting to draft to match the deprecation process status of the corresponding apache/lucene#202 pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/LUCENE-8682
@romseygeek's Feb 2019 patch applied to past point in repo history and then rebased forward with import related conflict resolved plus small tweaks and Solr Reference Guide update too.
The changes affect tests and documentation only so no CHANGES.txt entry and separate SOLR JIRA issue needed here in my opinion, but happy to have either or both if others think that would be better.