Add the virtual thread executor plugin #751
Conversation
| @@ -260,4 +260,6 @@ public class ComponentsDefine { | |||
| public static final OfficialComponent SOLON_MVC = new OfficialComponent(158, "SolonMVC"); | |||
|
|
|||
| public static final OfficialComponent CAFFEINE = new OfficialComponent(160, "Caffeine"); | |||
|
|
|||
| public static final OfficialComponent THREAD_PER_TASK_EXECUTOR = new OfficialComponent(161, "ThreadPerTask-executor"); | |||
There was a problem hiding this comment.
ID submitted through apache/skywalking#13090
| * CARRIER_THREAD represents the actual operating system thread that carries out the execution of the virtual thread. | ||
| */ | ||
| public static final StringTag CARRIER_THREAD = new StringTag(24, "carrier.thread"); |
There was a problem hiding this comment.
To follow the naming style, I think the thread.carrier is better?
There was a problem hiding this comment.
To follow the naming style, I think the
thread.carrieris better?
Yes, better, done.
|
Could you try to fix the deadlink? I think the previous link is pointing to very old repo, which should be changed to skywalking asf main repo. |
Done. |
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-deploy-plugin</artifactId> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
Could you check whether your new module could generate javadoc jar? Another plugin pom.xml has relative configurations to generate that file.
There was a problem hiding this comment.
Could you check whether your new module could generate javadoc jar? Another plugin pom.xml has relative configurations to generate that file.
When I added the maven-javadoc-plugin, I could generate the javadoc.jar
There was a problem hiding this comment.
Please add that plugin, otherwise, this will fail the release process.
CHANGESlog.