Add go 1.23 in docker image and remove 1.16-1.18 support. #194
Conversation
| base.image.go1.20 := golang:1.20 | ||
| base.image.go1.21 := golang:1.21 | ||
| base.image.go1.22 := golang:1.22 | ||
| base.image.go1.23 := golang:1.23 |
There was a problem hiding this comment.
I am good to add 1.23 added.
Meanwhile, according to go maintenance policy Each major Go release is supported until there are two newer major releases.. I think we at least only need to release N-4?
There was a problem hiding this comment.
go1.19.13 (released 2023-09-06) includes fixes to the go command, and the crypto/tls and net/http packages. See the Go 1.19.13 milestone on our issue tracker for details.
As N-4(1.19) was not released for nearly a year.
There was a problem hiding this comment.
Mostly, 1.18 should be the lowest version we plan to support.
There was a problem hiding this comment.
I refer to https://go.dev/doc/devel/release
There was a problem hiding this comment.
Ok. Then we can remove between the 16-19 versions?
There was a problem hiding this comment.
According to release note, we could at least remove 16, 17, 18, 19(this could consider to be kept).
There was a problem hiding this comment.
Sure, I will keep the 19 and higher versions.
There was a problem hiding this comment.
I will temporarily make this PR a draft to wait for all testing success because all older tests are based on go 1.18.
|
Do we have a doc to indicate lowest support version? We should update it. |
Yes, I have updated. |
|
About native http, the doc says supporting to 1.20. |
Done, all native frameworks have added tests for 1.23. |
Adjust the change log to highlight the key changes.
wu-sheng
changed the title
No description provided.