Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Squeezenet using Squeezenet1.1 #711

Merged
merged 6 commits into from
May 31, 2020

Conversation

agnesnatasya
Copy link
Contributor

Implemented Squeezenet model using Squeezenet1.1 model in ONNX model zoo.
As compared to the inference here https://github.com/onnx/models/blob/master/vision/classification/imagenet_inference.ipynb , which resizes the image to 256 and crop the 224 in the center, I resized the image to 224 and take all these 224 pixels as an input to the model. It gave different result when I tried these 2 approaches, but the second one gives more similar result. Thus, I choose the second one. Is there any significant impact of this difference?

@nudles
Copy link
Member

nudles commented May 28, 2020

@joddiy pls help review.

@joddiy
Copy link
Member

joddiy commented May 28, 2020

@joddiy pls help review.

sure, I'll review it soon. I'm working on the test_operations.py. I guess I will review this PR today later.

@agnesnatasya, Thanks for your commit, if you're free, you can continue to the next model. Please leave a comment about the model you chose in the #700 .

@joddiy
Copy link
Member

joddiy commented May 28, 2020

@agnesnatasya Thanks for your help! I've reviewed the code, it works fine, however, please refer to our code style here. After you reformat the code, it'd be ready to merge into the master.

And the result seems fine:

image

@agnesnatasya
Copy link
Contributor Author

Thank you @joddiy for the review, will make the change and will push again

@agnesnatasya
Copy link
Contributor Author

@joddiy The guide stated that "After the configuration, linting should be automatically applied when editing source code file". There is no warning in the "PROBLEMS" tab, but there are some warnings when I run pylint from terminal. However, other files like vgg16.py, also have these warnings when I run pylint on it.

Have reformatted with yapf.

Copy link
Member

@joddiy joddiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nudles ready to merge

@nudles
Copy link
Member

nudles commented May 31, 2020

@agnesnatasya @joddiy thanks!

@nudles nudles merged commit a00a23b into apache:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants