Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modifying Hikari-CP configurations via props in standalone mode #34185

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Support modifying Hikari-CP configurations via props in standalone mode #34185

merged 3 commits into from
Dec 28, 2024
+18 −5

Conversation

JoshuaChen
Copy link
Contributor

@JoshuaChen JoshuaChen commented Dec 28, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Support modifying Hikari-CP configurations via props in standalone mode

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@terrymanu terrymanu added this to the 5.5.2 milestone Dec 28, 2024
@terrymanu terrymanu merged commit 0a1c8e5 into apache:master Dec 28, 2024
147 checks passed
@terrymanu terrymanu mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
mode: standalone type: enhancement
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaChen @terrymanu