Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alter index sql bind and add test case #34160

Merged
merged 46 commits into from
Dec 26, 2024
Merged

Conversation

YaoFly
Copy link
Contributor

@YaoFly YaoFly commented Dec 26, 2024

Ref #34029.
Changes proposed in this pull request:

  • Support alter index sql bind and add test case.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@YaoFly
Copy link
Contributor Author

YaoFly commented Dec 26, 2024

@strongduanmu PLAT. There are some conflicts that need to be resolved here.

YaoFly and others added 2 commits December 26, 2024 15:54
# Conflicts:
#	infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/type/DDLStatementBindEngine.java
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so great, merged.

@strongduanmu strongduanmu merged commit ad02d16 into apache:master Dec 26, 2024
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants