Skip to content

Conversation

@jbampton
Copy link
Member

Clean up the pre-commit config fixing indentation and using more readable multiline regex

After updating the pre-commit version of clang-format we had some new formatting changes in c and h files.

Added an ignore in the markdownlint config for MD060 a new rule.

https://nodejs.org/en/download

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • No:
    • this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

As described above

How was this patch tested?

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

Clean up the pre-commit config fixing indentation and using more readable multiline regex

After updating the pre-commit version of clang-format we had some new formatting changes in c and h files.

Added an ignore in the markdownlint config for MD060 a new rule.
@jbampton jbampton requested a review from jiayuasu as a code owner November 27, 2025 21:26
@github-actions github-actions bot added sedona-python github_actions Pull requests that update GitHub Actions code root labels Nov 27, 2025
@jiayuasu jiayuasu requested a review from Kontinuation December 2, 2025 00:29
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Kontinuation does this look good to you?

@Kontinuation
Copy link
Member

The large body of changes made to the C code comes from the clang-format upgrade: llvm/llvm-project#149602. The latest Google C++ style enforced pointer alignment so clang-format does not follow the pointer alignment style of the existing code. This change looks fine to me, although I am personally more used to the old style.

@jiayuasu
Copy link
Member

jiayuasu commented Dec 3, 2025

OK. @jbampton Can we stick to the old format?

@jbampton
Copy link
Member Author

On my local machine I ran: clang-format -style=Google -dump-config > .clang-format

Then edited two lines in the .clang-format file to align the pointer to the right.

And I removed the argument for "Style Google" from the clang format hook.

# .clang-format
DerivePointerAlignment: false
PointerAlignment: Right

Updated the pre-commit config again it moves quickly

https://nodejs.org/en/download

https://www.npmjs.com/package/prettier

@jiayuasu jiayuasu merged commit a4b45a5 into apache:master Dec 11, 2025
9 checks passed
@jbampton jbampton deleted the clean-up-pre-commit branch December 11, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code root

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants