Feat/remove flink scala deps #2516
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subham-KRLX
force-pushed
the
feat/remove-flink-scala-deps
branch
from
a57f066 to
51a07c6
Compare
Subham-KRLX
force-pushed
the
feat/remove-flink-scala-deps
branch
from
51a07c6 to
d2474ef
Compare
Contributor
Author
Member
|
You opened the PR 4 days ago and then on the same day you send another message tagging two committers. Please don't send this extra message straight away. We are "watching" the Sedona repo and we do get notifications of all PRs and issues opened. There are many PRs and issues in play please try to be more patient. For an example on CPython there are over 2k PRs and over 1k PRs awaiting review: https://github.com/python/cpython/pulls?q=is%3Apr+is%3Aopen+label%3A%22awaiting+review%22 |
Contributor
Author
|
Thanks for letting me know.Understood I’ll wait patiently and won’t send another ping so soon. |
Member
|
this PR does not solve the issue. I don't think you actually understand it and this is harder than you think. Please don't work on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-2457] Remove Flink Scala dependency. Closes Remove Flink Scala dependency #2457What changes were proposed in this PR?
According to Flink FLIP 265, the Flink community has decided to drop Scala API. Flink now also offers pure Java dependencies. This PR removes Flink Scala dependencies from Sedona to align with this change.
Key changes:
flink/pom.xml:artifactIdfromsedona-flink_${scala.compat.version}tosedona-flink.flink-table-planner_${scala.compat.version}withflink-table-planner-loader.scala-librarydependency.flink-shaded/pom.xmlto depend on the newsedona-flinkartifact.How was this patch tested?
mvn clean install -pl flink -am.mvn test -pl flink -am.Did this PR include necessary documentation updates?