Skip to content

Conversation

@Subham-KRLX
Copy link
Contributor

@Subham-KRLX Subham-KRLX commented Nov 21, 2025

Did you read the Contributor Guide?

  • Yes, I have read the Contributor Rules and Contributor Development Guide

Is this PR related to a ticket?

What changes were proposed in this PR?

Adds to_sedonadb() method to SedonaSpark DataFrame for easy conversion to SedonaDB DataFrame.

Features:

  • Checks if sedona.db is installed (raises ImportError if missing)
  • Accepts optional connection parameter (creates new connection if not provided)
  • Uses dataframe_to_arrow() for conversion

How was this patch tested?

Added python/tests/test_to_sedonadb.py with mocked tests verifying both connection scenarios.

Did this PR include necessary documentation updates?

  • Yes, adding new API with current SNAPSHOT version

@Subham-KRLX
Copy link
Contributor Author

@jiayuasu please check this out.

@jbampton jbampton marked this pull request as draft December 12, 2025 04:58
@jbampton jbampton self-assigned this Dec 12, 2025
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now marked as a draft.

Firstly your commit description is all messed up and not filled in correctly.

You also need a much better PR title that is more descriptive and you can edit that on the GitHub website there is a button for that.

And please don't mix different changes in one PR. For example you are editing the docs workflow YAML file and also adding Python code for another feature.

If you want your PRs to be reviewed and merged quickly you need to work harder and make it very easy for the committers

@Subham-KRLX Subham-KRLX marked this pull request as ready for review December 12, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add to_sedonadb() method

2 participants