Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Doc]Move the introduction of map-store configuration to the SeaTunnel Engine Network Services section #8335

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xiaochen-zhou
Copy link
Contributor

@xiaochen-zhou xiaochen-zhou commented Dec 19, 2024

Purpose of this pull request

The introduction of map-store configuration is inconsistent between the chapters in separated-cluster-deployment.md and hybrid-cluster-deployment.md. I think it should belong to the hazelcast.yaml configuration content and perhaps should be unified in section 5.3.

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist tests

Check list

@@ -382,6 +284,106 @@ TCP is the way we recommend to use in a standalone SeaTunnel Engine cluster.

On the other hand, Hazelcast provides some other service discovery methods. For details, please refer to [hazelcast network](https://docs.hazelcast.com/imdg/4.1/clusters/setting-up-clusters).

### 5.3 Persistence Configuration of IMap (This parameter is invalid on the Worker node)
Copy link
Member

@Hisoka-X Hisoka-X Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section 5 named Configuring SeaTunnel Engine Network Services. So I think we should not put Imap Configuration in here. It is a part of Configure SeaTunnel Engine

I found hybrid-cluster-deployment.md like this, maybe we should change the section title

@Hisoka-X
Copy link
Member

By the way, can you help us organize the same configuration of these two documents into a new document? It is a bit cumbersome to maintain two identical documents at the same time.

@xiaochen-zhou
Copy link
Contributor Author

By the way, can you help us organize the same configuration of these two documents into a new document? It is a bit cumbersome to maintain two identical documents at the same time.

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants