Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default panic handler could be customized #1182

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

twz915
Copy link
Contributor

@twz915 twz915 commented Dec 12, 2024

What is the purpose of the change

#1074 (comment)

in old version, we could do this

primitive.PanicHandler = func(i interface{}) {
     msentry.CaptureMessage(fmt.Sprintf("%+v", i), nil)
}

but in latest version, default panic handler could not be customized.

when push consume panic, default panic handler should be called (we log and monitor the panic in default panic handler)
image

@ShannonDing ShannonDing merged commit abae4a0 into apache:master Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants