Move request ID generator configuration to polaris.tracing #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
reviewed
Oct 3, 2025
| # under the License. | ||
| # | ||
|
|
||
| org.apache.polaris.service.config.ConfigRelocationInterceptor No newline at end of file |
| # polaris.metrics.tags.region=us-west-2 | ||
|
|
||
| polaris.tracing.request-id-generator.type=default | ||
| polaris.tracing.request-id-generator.header-name=Polaris-Request-Id |
There was a problem hiding this comment.
minor / optional : does the header name has to to do anything with the generator, wondering if we just reuse the name we had earlier, WDYT ?
Suggested change
| polaris.tracing.request-id-generator.header-name=Polaris-Request-Id | |
| polaris.tracing.request-id-header-name=Polaris-Request-Id |
Comment on lines
+56
to
+58
| * The property `polaris.log.request-id-header-name` has been renamed to | ||
| `polaris.tracing.request-id-generator.header-name`; the old name is still supported for backwards | ||
| compatibility, but will generate a warning. |
There was a problem hiding this comment.
should we use word deperecated ?
|
@singhpk234 thanks for the review, but due to the Helm chart test failures, I think we need to find a new root for the request ID configuration. Mixing it with Let me put this into draft state and think a bit more about this. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2720 (comment)
I moved everything to the
polaris.tracingconfig root because it was the easiest move, but we could move the configuration to some other root – just let me know.The old config is still supported.