Increase javadoc visibility in :polaris-async-vertx
#2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanhemani
approved these changes
Oct 2, 2025
snazy
previously approved these changes
Oct 2, 2025
There was a problem hiding this comment.
I don't mind this change per-se.
Generally I think it is better to keep implementations as "protected" as possible.
JavaPoolAsyncExec is public only for testing purposes.
Can we update the javadoc to just not emit the warning? Or let javadoc emit docs for package-protected types ((options as StandardJavadocDocletOptions).showFromPackage())
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Sadly, it's an "error" (shows up pretty prominently in IJ)... I'll see about addressing it without making the class 
|
This is to fix javadoc error: `No public or protected classes found to document`
dimas-b
changed the title
:polaris-async-vertx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix javadoc error:
No public or protected classes found to document