Add support for MySQL Metastore #2704
Conversation
| runtimeOnly("org.postgresql:postgresql") | ||
| runtimeOnly(project(":polaris-relational-jdbc")) | ||
| runtimeOnly("io.quarkus:quarkus-jdbc-postgresql") | ||
| implementation(libs.mysql.connector.j) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, the connector license is not compatible with ASF, AFAIK.
There was a problem hiding this comment.
Sorry, missed this conversation, maybe I will create documentation later on which references this PR on how to get MySQL support if needed.
There was a problem hiding this comment.
Everything except the driver is acceptable, I think.
So, @Jayden-Chiu : you may want to keep the java code changes, but remove the driver dependency. That would be mergeable from my POV (pending reviews from other maintainers, of course). Then, instructions on bundling MySQL Connector in a local build could be much simpler.
If the instructions for downstream builds with MySQL were added to a README or docs, that would make a well-rounded PR, from my POV.
There was a problem hiding this comment.
Why add earlier schemas? MySQL was not supported when v1 was current 🤔
There was a problem hiding this comment.
Since this is currently only checked within a persistence impl, these version numbers are also per persistence impl. There's no requirement that MySQL vN align with postgres vN.
There was a problem hiding this comment.
So rather than just starting with mysql v3, you could just start with mysql v1 with all the tables that postgres v3 has.
4 participants
As discussed in #2491 , there is currently no support for MySQL as a metastore. many organizations (mine included) rely on existing MySQL infrastructure and this PR adds MySQL support to the
relational-jdbcmodule with tests. This PR mostly extends existing code for Postgres support, adding MySQL toDatabaseTypeenum, and changing existing methods to handle MySQLDatabaseTypeand adding MySQL JDBC driver topersistence/relational-jdbc/build.gradle.ktsandruntime/server/build.gradle.kts