Skip to content

Request-scoped PolarisMetaStoreManager #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Request-scoped PolarisMetaStoreManager #2555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccbb4ce
Request-scoped PolarisMetaStoreManager
XN137 Sep 4, 2025
0eb0f2b
inject PolarisMetaStoreManager into DefaultOAuth2ApiService
XN137 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...ris/extension/persistence/impl/eclipselink/EclipseLinkPolarisMetaStoreManagerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.nio.file.Path;
import java.time.Clock;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.config.PolarisConfigurationStore;
import org.apache.polaris.core.context.RealmContext;
import org.apache.polaris.core.persistence.LocalPolarisMetaStoreManagerFactory;
import org.apache.polaris.core.persistence.PolarisMetaStoreManager;
Expand All @@ -48,12 +49,13 @@ public class EclipseLinkPolarisMetaStoreManagerFactory

@SuppressWarnings("unused") // Required by CDI
protected EclipseLinkPolarisMetaStoreManagerFactory() {
this(null, null);
this(null, null, null);
}

@Inject
protected EclipseLinkPolarisMetaStoreManagerFactory(Clock clock, PolarisDiagnostics diagnostics) {
super(clock, diagnostics);
protected EclipseLinkPolarisMetaStoreManagerFactory(
Clock clock, PolarisDiagnostics diagnostics, PolarisConfigurationStore configurationStore) {
super(clock, diagnostics, configurationStore);
}

@Override
Expand Down
118 changes: 38 additions & 80 deletions ...olaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 3 additions & 6 deletions ...olaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@
import java.nio.file.Path;
import java.util.Objects;
import java.util.stream.Stream;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.PolarisDefaultDiagServiceImpl;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.context.RealmContext;
import org.apache.polaris.core.entity.PolarisPrincipalSecrets;
import org.apache.polaris.core.persistence.BasePolarisMetaStoreManagerTest;
import org.apache.polaris.core.persistence.PolarisTestMetaStoreManager;
Expand Down Expand Up @@ -83,14 +81,13 @@ static void prepareConfFiles(@TempDir Path archiveDir) throws IOException {
protected PolarisTestMetaStoreManager createPolarisTestMetaStoreManager() {
PolarisDiagnostics diagServices = new PolarisDefaultDiagServiceImpl();
PolarisEclipseLinkStore store = new PolarisEclipseLinkStore(diagServices);
RealmContext realmContext = () -> "realm";
PolarisEclipseLinkMetaStoreSessionImpl session =
new PolarisEclipseLinkMetaStoreSessionImpl(
diagServices, store, Mockito.mock(), realmContext, null, "polaris", RANDOM_SECRETS);
TransactionalMetaStoreManagerImpl metaStoreManager =
new TransactionalMetaStoreManagerImpl(clock, diagServices);
PolarisCallContext callCtx = new PolarisCallContext(realmContext, session);
return new PolarisTestMetaStoreManager(metaStoreManager, callCtx);
new TransactionalMetaStoreManagerImpl(
clock, diagServices, realmContext, realmConfig, () -> session);
return new PolarisTestMetaStoreManager(metaStoreManager);
}

@ParameterizedTest
Expand Down
Loading