Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site integration 3.x.x Migration - Doxia Modules 3+ #1419

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Site integration 3.x.x Migration - Doxia Modules 3+ #1419

wants to merge 1 commit into from

Conversation

ottlukas
Copy link
Contributor

Rename the maven-site-plugin dependency from asciidoctor-maven-plugin to asciidoctor-converter-doxia-module.

@ottlukas
https://docs.asciidoctor.org/maven-tools/latest/site-integration/v3-m…
37d0b45 
…igration-guide/ ->Rename the maven-site-plugin dependency from asciidoctor-maven-plugin to asciidoctor-converter-doxia-module.
@ottlukas ottlukas requested a review from sruehl February 22, 2024 09:19
@ottlukas ottlukas self-assigned this Feb 22, 2024
@ottlukas ottlukas added the documentation Missing documentation , adding documentation label Feb 22, 2024
@ottlukas
Copy link
Contributor Author

https://docs.asciidoctor.org/maven-tools/latest/site-integration/v3-migration-guide/ ->Rename the maven-site-plugin dependency from asciidoctor-maven-plugin to asciidoctor-converter-doxia-module.

@ottlukas ottlukas changed the title https://docs.asciidoctor.org/maven-tools/latest/site-integration/v3-migration-guide/ ->Rename the maven-site-plugin dependency from asciidoctor-maven-plugin to asciidoctor-converter-doxia-module. Site integration 3.x.x Migration - Doxia Modules 3+ Feb 22, 2024
@sruehl sruehl requested a review from chrisdutz February 22, 2024 09:47
@sruehl sruehl mentioned this pull request Feb 23, 2024
Draft
@chrisdutz
Copy link
Contributor

The asciidoctor folks have an open PR for this, but they said they will only work on this as soon as the site plugin is final ... so I guess we have to wait for the site plugin to be finally released and then for the asciidoctor folks to update the plugin. Till then we should stay at 2.x.x

@chrisdutz chrisdutz marked this pull request as draft March 23, 2024 17:42
@ottlukas
Copy link
Contributor Author

The asciidoctor folks have an open PR for this, but they said they will only work on this as soon as the site plugin is final ... so I guess we have to wait for the site plugin to be finally released and then for the asciidoctor folks to update the plugin. Till then we should stay at 2.x.x

@chrisdutz can you link in the mentioned Pull request in asciidoctor? Thank you!

@ottlukas ottlukas added the awaiting-feedback This label is applied when an issue has been opened and we need more information from the issuer. label Sep 12, 2024
@chrisdutz
Copy link
Contributor

I have been looking into updating the site and the asciidoctor plugin ... however this seems to require quite some work and possibly a new site skin.

@chrisdutz
Copy link
Contributor

Here's the PR in the asciidoctor-maven-plugin that I was talking about: asciidoctor/asciidoctor-maven-plugin#685

@hutcheb
Copy link
Contributor

hutcheb commented Dec 24, 2024

This shouldn’t be relevant anymore due to the website update but can take a better look on the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruehl sruehl Awaiting requested review from sruehl

@chrisdutz chrisdutz Awaiting requested review from chrisdutz

Assignees

@ottlukas ottlukas

Labels
awaiting-feedback This label is applied when an issue has been opened and we need more information from the issuer. documentation Missing documentation , adding documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ottlukas @chrisdutz @hutcheb