[draft] Run tests with Corretto 21

[gortiz]

This PR tries to run Pinot tests with Java 21 while compiling with Java 11. The reason to do not compile with Java 21 is explained in #11656

[codecov-commenter]

Codecov Report

Merging #11657 (40ab653) into master (3501b86) will decrease coverage by 63.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11657       +/-   ##
=============================================
- Coverage     63.06%    0.00%   -63.07%     
=============================================
  Files          2342     2342               
  Lines        125690   125692        +2     
  Branches      19306    19309        +3     
=============================================
- Hits          79262        0    -79262     
- Misses        40778   125692    +84914     
+ Partials       5650        0     -5650     

Flag	Coverage Δ
corretto	0.00% <0.00%> (?)
integration	0.00% <0.00%> (-0.01%)	⬇️
integration1	?
integration2	?
java-11	?
java-17	?
java-20	?
java-21	0.00% <0.00%> (?)
temurin	?
unittests	?
unittests1	?
unittests2	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ache/pinot/segment/spi/memory/PinotDataBuffer.java	0.00% <0.00%> (-79.44%)	⬇️

... and 1945 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[xiangfu0]

shall we use openjdk 21 or corretto?

[gortiz]

shall we use openjdk 21 or corretto?

If there is a serious alternative to openjdk docker images, we should always use the alternative. The reason is explained in the deprecation note of https://hub.docker.com/_/openjdk. Openjdk is not production ready. It is the image that is created from the master branch of openjdk repo. That means that openjdk will only create images for the first 6 months for each version, even LTS. For example, Java 21 images won't be created once Java 22 is released.

That is why we choose to use either Temurin (old adoptjdk), Microsoft or Corretto. As of today, only Corretto provides a Java 21 image, so that is the one I've chosen here. We can change to Temurin once it is released in order to have an homogeneous pipeline.

[gortiz]

It seems there are some issues with this PR. I've tried a different (and probably better) approach in #11672.

While this PR (#11657) changes the pipeline to compile with Java 11 and run tests with Java 21, #11672 actually compiles with Java 21 and tries to fix the issues we have (or disable in Java 21 the ones that cannot be fixed as today, like spotless). Therefore it seems that #11672 is better as it is less hacky and closer to the actual pipeline we would like to have once Java 21 is fully supported.